Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not create file if not writing #2815

Merged
merged 5 commits into from
May 16, 2024
Merged

Do not create file if not writing #2815

merged 5 commits into from
May 16, 2024

Conversation

mathomp4
Copy link
Member

@mathomp4 mathomp4 commented May 8, 2024

Types of change(s)

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Trivial change (affects only documentation or cleanup)

Checklist

  • Tested this change with a run of GEOSgcm
  • Ran the Unit Tests (make tests)

Description

This PR updates the checkpoint_simulator to not create and close file if not writing

Also fixes some documentation.

Related Issue

@mathomp4 mathomp4 added the 0 Diff Trivial The changes in this pull request are trivially zero-diff (documentation, build failure, &c.) label May 8, 2024
@mathomp4 mathomp4 self-assigned this May 8, 2024
@mathomp4 mathomp4 requested a review from a team as a code owner May 8, 2024 17:32
@mathomp4 mathomp4 merged commit 5794f19 into develop May 16, 2024
36 checks passed
@mathomp4 mathomp4 deleted the feature/mathomp4/update-checkpoint-sim branch May 16, 2024 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tclune tclune tclune approved these changes

Assignees

@mathomp4 mathomp4

Labels
0 Diff Trivial The changes in this pull request are trivially zero-diff (documentation, build failure, &c.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mathomp4 @tclune