-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IO prototype for History (and checkpoint) #2814
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bena-nasa
added
the
0 Diff
The changes in this pull request have verified to be zero-diff with the target branch.
label
May 7, 2024
tclune
reviewed
May 8, 2024
tclune
reviewed
May 8, 2024
tclune
reviewed
May 8, 2024
tclune
reviewed
May 8, 2024
tclune
reviewed
May 8, 2024
tclune
previously approved these changes
May 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a good start.
My inline comments are all about long term evolution of this layer. Nothing actionable at the moment.
bena-nasa
added
the
0 Diff Trivial
The changes in this pull request are trivially zero-diff (documentation, build failure, &c.)
label
May 8, 2024
tclune
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
0 Diff Trivial
The changes in this pull request are trivially zero-diff (documentation, build failure, &c.)
0 Diff
The changes in this pull request have verified to be zero-diff with the target branch.
📈 MAPL3
MAPL 3 Related
🎁 New Feature
This is a new feature
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following @tclune slides about the GeomIO, propose an abstract GEOM_IO layer that works with PFIO and a concrete grid class that only supports 2D, R4 output and would need a vast amount of generalization for all the different types/ranks/grid types (cube, lat/lon, etc)
Also add a geomCatagorizer function to instantiate the right GEOM_IO concrete class (that only supports grid cause there's nothing else we have besides grids).
Also adds a IOShared layer that has a bunch of utilities procedures that can be used for both history and checkpointing. For example a procedure to take a bundle and create a file metadata object (what we can so far...)
In the future I envision the we can also create a GEOM_IO layer that can implement the old gather/scatter strategy rather than using PFIO as the disk access for checkpoints.
Names need work, just wanted to get something committed and a draft.
Note this does work, I can now output multiple timestep files in History3G albeit only 2D gridded files.
Checklist
make tests
)Description
Related Issue