Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is needed for building GEOSgcm with spack-stack (see JCSDA/spack#174).
Here we update the main
CMakeLists.txt
for the case where Baselibs is not found so that all the neededfind_package()
andadd_library(ALIAS)
calls can be made. Testing shows that this is zero-diff.I've also added a test for the
esmf_ROOT
environment variable that Spack creates and use that to find theFindESMF.cmake
file. Not perfect, but now when building by hand you don't have to do-DCMAKE_MODULE_PATH=${esmf_ROOT}/cmake
.Also, this adds a smidge of the changes needed for FMS-in-spack. I can't turn this on by default due to changes that are needed in fvdycore (see GEOS-ESM/GFDL_atmos_cubed_sphere#51). As this is an interface change, we have to go whole-hog into it.
Related PRs that are NOT necessary, just future proofing for FMS-in-Baselibs/FMS-in-spack:
develop
(And there is also GEOS-ESM/ESMA_env#82 but this is going to be a ways away...)