Feature/jstassi/#98 convert scripts to python3 #99
Conversation
…c.py, and associated unittests to Python 3.
Merge branch 'develop' into feature/jstassi/#98-Convert_scripts_to_Python3
gmao-jstassi
added
the
0 diff trivial
|
Ricardo, these updates are utility programs that do not have any impact on DAS processing. |
There was a problem hiding this comment.
Joe,
I might have been distract when this come into the develop - I don't actually recall ever approving this stuff ... but that's besides the point.
I can't approve this as is. This needs major cleaning.
Why are there copies of RC files from ETC in the input directory of the python utils you added - I know this has been the case for a while, but I don't recall approving this. Regardless, it cannot be as is
-
What is there an outdir w/ a single README file ... this seem like something that should be created when user run you software somewhere else outside the source code ... this dir should not be here.
-
what are all these files? Why are some of these files copy of each other? e.g.: check_summary.satbang_full_rst check_summary.satbang_full_rst.orig are identical. Are these files output of a run using your software ... why should they be in the repo at all.
Sorry, but I think this needs some attention before it can be taken into the tag.
|
Ricardo, all the files that you mention are in the unittests subdirectory. These files are not included in the build. Their only purpose is to test the Python scripts in the GSI_GridComp/etc directory, to verify that the scripts give expected output after being modified. That seems like a useful thing to have. The unittests/outdir subdirectory with its README file were previously in the repository but have been deleted with this PR. |
|
Why can't you design your test so that it runs off the RC files in the ETC directory of the installation? Why should you copy files from gsi/etc into your unit-test env. Sorry, but I still think there is a level of clean up to be done here. You haven't explained to me why you need files that identical to be in the repo w/ different names! |
|
Ricardo, my tests check for expected output from a given input, so if I used the rc files in the etc directory as my input, then I would have to update my tests every time somebody updates the rc files in the etc directory.
Some of my tests read an rc file and then write it back out, which for a successful test means that the output is going to be identical to the input. I think that is what you are seeing when two files with different names are identical.
…________________________________
From: rtodling ***@***.***>
Sent: Monday, August 15, 2022 3:22 PM
To: GEOS-ESM/GEOSana_GridComp ***@***.***>
Cc: Stassi, Joe (GSFC-610.1)[SCIENCE SYSTEMS AND APPLICATIONS INC] ***@***.***>; Author ***@***.***>
Subject: [EXTERNAL] Re: [GEOS-ESM/GEOSana_GridComp] Feature/jstassi/#98 convert scripts to python3 (PR #99)
Why can't you design your test so that it runs off the RC files in the ETC directory of the installation? Why should you copy files from gsi/etc into your unit-test env. Sorry, but I still think there is a level of clean up to be done here. You haven't explained to me why you need files that identical to be in the repo w/ different names!
—
Reply to this email directly, view it on GitHub<https://gcc02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FGEOS-ESM%2FGEOSana_GridComp%2Fpull%2F99%23issuecomment-1215644398&data=05%7C01%7Cjoe.stassi%40nasa.gov%7C95ceb4ddf7184f12c7eb08da7ef3926e%7C7005d45845be48ae8140d43da96dd17b%7C0%7C0%7C637961881844256456%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=sdrSWan3bWEMKeLGT5XMckrUJG17f6CRMWCUt6xIdRE%3D&reserved=0>, or unsubscribe<https://gcc02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAMBAJ2VUL6FVBFKGLF2SFDLVZKKJHANCNFSM56JIPAVA&data=05%7C01%7Cjoe.stassi%40nasa.gov%7C95ceb4ddf7184f12c7eb08da7ef3926e%7C7005d45845be48ae8140d43da96dd17b%7C0%7C0%7C637961881844256456%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=cgBXKAFhuzO3LB3NvB7%2BnACqE9ZVgq7JIQTG8uG2seM%3D&reserved=0>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
No description provided.