Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix up ADAS CI #297

Merged
merged 4 commits into from
Nov 12, 2024
Merged

Fix up ADAS CI #297

merged 4 commits into from
Nov 12, 2024

Conversation

mathomp4
Copy link
Member

@mathomp4 mathomp4 commented Nov 4, 2024

This PR attempts to fix the ADAS CI. The changes are:

  1. Update to GMAOpyobs v1.0.6.1 which allows for not building f2py code in CI (see GEOS-ESM/GMAOpyobs@v1.0.6...v1.0.6.1)
  2. Backs off the circleci-tools orb to v2.10 which is before Intel 2021.13 came in

@mathomp4 mathomp4 added the 0 diff The changes in this pull request have verified to be zero-diff with the target branch. label Nov 4, 2024
@mathomp4 mathomp4 self-assigned this Nov 4, 2024
@mathomp4 mathomp4 marked this pull request as ready for review November 4, 2024 17:34
@mathomp4 mathomp4 requested review from a team as code owners November 4, 2024 17:34
@mathomp4
Copy link
Member Author

mathomp4 commented Nov 4, 2024

It worked! Yay!

@rtodling
Copy link
Collaborator

@mathomp4 Why does this take so long to run the CI tests?

@mathomp4
Copy link
Member Author

@mathomp4 Why does this take so long to run the CI tests?

Huh. I did not notice that. Something must be wonky. Let me take a look...

@mathomp4
Copy link
Member Author

I just tried a push of a quick fix. I don't think it's perfect, but should make the build faster I hope.

@rtodling
Copy link
Collaborator

I just tried a push of a quick fix. I don't think it's perfect, but should make the build faster I hope.

I just tried a push of a quick fix. I don't think it's perfect, but should make the build faster I hope.

ok - thank you.

@mathomp4
Copy link
Member Author

I just tried a push of a quick fix. I don't think it's perfect, but should make the build faster I hope.

ok - thank you.

The "real" issue seems to be the compiler in CI land is dying trying to compile a file...but then it works the next time around. Obviously the file compiles on discover, etc., so my only thought is maybe I just need less make parallelism for that one file (i.e., compiler running out of memory?). Fingers crossed!

@rtodling
Copy link
Collaborator

hum - that's odd - that's no happened to me once ... and I have compiled numerous times. perhaps the compilation in the CI is not quite one-to-one w/ how things get compiled in actuality, could that be?

Copy link
Collaborator

@rtodling rtodling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems good by me. Thank you.

@rtodling rtodling merged commit c7a1e71 into develop Nov 12, 2024
4 checks passed
@mathomp4 mathomp4 deleted the feature/mathomp4/fix-adas-ci-try3 branch November 12, 2024 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 diff The changes in this pull request have verified to be zero-diff with the target branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants