Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

R21C DAS Candidate #268

Merged
merged 11 commits into from
Mar 7, 2024
Merged

R21C DAS Candidate #268

merged 11 commits into from
Mar 7, 2024

Conversation

sdrabenh
Copy link

No description provided.

Copy link

Label error. Requires at least 1 of: 0 diff, 0 diff trivial, Non 0-diff, 0 diff structural, 0-diff trivial, Not 0-diff, 0-diff, automatic, 0-diff uncoupled. Found:

Copy link

Label error. Requires at least 1 of: 0 diff, 0 diff trivial, Non 0-diff, 0 diff structural, 0-diff trivial, Not 0-diff, 0-diff, automatic, 0-diff uncoupled. Found:

Copy link

Label error. Requires at least 1 of: 0 diff, 0 diff trivial, Non 0-diff, 0 diff structural, 0-diff trivial, Not 0-diff, 0-diff, automatic, 0-diff uncoupled. Found:

Copy link

github-actions bot commented Mar 1, 2024

Label error. Requires at least 1 of: 0 diff, 0 diff trivial, Non 0-diff, 0 diff structural, 0-diff trivial, Not 0-diff, 0-diff, automatic, 0-diff uncoupled. Found:

@sdrabenh sdrabenh marked this pull request as ready for review March 1, 2024 14:14
@sdrabenh sdrabenh requested review from a team as code owners March 1, 2024 14:14
@sdrabenh
Copy link
Author

sdrabenh commented Mar 1, 2024

@rtodling @elakkraoui I updated this PR to use the new tags in GEOSana_GridComp and GMAO_Shared. This PR has been undrafted and is ready for approval, merging and tagging.

Copy link
Collaborator

@rtodling rtodling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We certainly seem to have a system within a system!

@elakkraoui
Copy link

elakkraoui commented Mar 7, 2024 via email

@rtodling rtodling added the Non 0-diff The changes in this pull request are non-zero-diff label Mar 7, 2024
@mathomp4
Copy link
Member

mathomp4 commented Mar 7, 2024

I have just merged in GEOS-ESM/GEOSgcm_App#589 from @amolod . Should I make a tag with that update for GEOSgcm_App and update this PR?

@mathomp4 mathomp4 merged commit c43bf6a into R21C Mar 7, 2024
5 of 6 checks passed
@mathomp4 mathomp4 deleted the feature/sdrabenh/r21c_DAScandidate branch March 7, 2024 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Non 0-diff The changes in this pull request are non-zero-diff
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants