Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updates for handling forcing outputs in ladas cycling #265

Closed
wants to merge 5 commits into from

Conversation

saraqzhang
Copy link
Contributor

modified:   src/Applications/GEOSdas_App/GEOSdas.csm
modified:   src/Applications/GEOSdas_App/fvpsas

	modified:   src/Applications/GEOSdas_App/GEOSdas.csm
	modified:   src/Applications/GEOSdas_App/fvpsas
@saraqzhang saraqzhang requested a review from a team as a code owner October 18, 2023 18:14
@github-actions
Copy link

Label error. Requires at least 1 of: 0 diff, 0 diff trivial, Non 0-diff, 0 diff structural, 0-diff trivial, Not 0-diff, 0-diff, automatic, 0-diff uncoupled. Found:

mkdir -p $FVHOME/recycle/holdforc
/bin/cp *2d_lfo*nc4 $FVHOME/recycle/holdforc/
endif
#if ( $LDAS_ANA ) then
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the if condition here intentionally commented out? Based on a quick look it seems that the if condition should be there, but I might be wrong.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gmao-rreichle , that block was leftover from before, I forgot to delete it in the update. I will do it now the push the change. thanks for spotting it.

@gmao-rreichle gmao-rreichle added the 0 diff trivial The changes in this pull request are trivially zero-diff (documentation, build failure, &c.) label Oct 18, 2023
@gmao-rreichle gmao-rreichle marked this pull request as draft October 18, 2023 18:21
@saraqzhang saraqzhang added 0 diff The changes in this pull request have verified to be zero-diff with the target branch. and removed 0 diff trivial The changes in this pull request are trivially zero-diff (documentation, build failure, &c.) labels Oct 18, 2023
gmao-rreichle
gmao-rreichle previously approved these changes Oct 18, 2023
@gmao-rreichle gmao-rreichle added 0 diff trivial The changes in this pull request are trivially zero-diff (documentation, build failure, &c.) and removed 0 diff The changes in this pull request have verified to be zero-diff with the target branch. labels Oct 18, 2023
@gmao-rreichle
Copy link
Contributor

Looks ok to me, but I'm not the judge here.
I changed the label to "0 diff trivial" because the edits are all within if ( $LDAS_ANA ) blocks.
@rtodling, from what I understand, this fix is needed because recent ADAS changes broke the weakly-coupled land assimilation.

@mathomp4
Copy link
Member

The force push above was:

gh repo clone GEOS-ESM/GEOSadas GEOSadas-Reset
cd GEOSadas-Reset
git checkout feature/saraqzhang/ladasupdate
git reset HEAD~5
git add .
git commit -m "fixed typo for zeit_c?.x MovePredictorOutput (fvpsas)"
git push --force origin feature/saraqzhang/ladasupdate

The add was for the "fix misspelling" commit that was previously there.

    add a sample ladas input file to testsuites
@saraqzhang
Copy link
Contributor Author

saraqzhang commented Feb 16, 2024

@gmao-rreichle @rtodling
I updated the prompts and defaults concerning LDAS coupling in fvsetup and added the sample input file for ladas setup into testsuites/

@saraqzhang
Copy link
Contributor Author

the changes here are consolidated into PR #275.

@saraqzhang saraqzhang closed this Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 diff trivial The changes in this pull request are trivially zero-diff (documentation, build failure, &c.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants