Feature/jstassi/#230/edhist python #231
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…did not trip the edhist.pl (perl) script, but it is a bug nonetheless.
…ave no impact until calls to edhist.pl (perl) are changed to edhist.py (python).
gmao-jstassi
added
the
0 diff trivial
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes two python scripts, history_rc.py and edhist.py, which can replace edhist.pl (perl).
These updates can be accepted and will have no impact at all, until calls to edhist.pl (perl) are replaced with edhist.py (python).
There is also a one-line bug fix in fvsetup. The bug does not affect the perl script, edhist.pl, but it causes the python version, edhist.py, to fail. Fixing it has no impact on the perl version.
Currently, the edhist.py script is hard-coded to point to python3 on the top line. This should be generalized whenever python3 (version 3.9.9 or higher) becomes part of the system. Beware that the script will not work with the current default python3 (version 3.4.6).