Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/jstassi/#83/#119/aod parallel and runjob consistency check #137

Conversation

gmao-jstassi
Copy link
Contributor

Issues
#83 Logic to run AOD in parallel and wait rather than running as a separate job
#119 Updates for runjob to check consistency between input file and fvsetup

@gmao-jstassi gmao-jstassi requested review from a team as code owners November 30, 2021 21:33
Copy link
Collaborator

@tclune tclune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cmake changes ok. The name "CVSTAG" seems a bit dated now though.

@gmao-jstassi gmao-jstassi added the 0 diff trivial The changes in this pull request are trivially zero-diff (documentation, build failure, &c.) label Dec 1, 2021
@gmao-jstassi
Copy link
Contributor Author

The "CVSTAG" variable was already in the file and was not added with the updates; though there was a line format modification (but no code change) which would cause the name to show up in a list of diffs.

Copy link
Collaborator

@rtodling rtodling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These seem fine w/ me.

@rtodling rtodling merged commit d9ce92f into develop Dec 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 diff trivial The changes in this pull request are trivially zero-diff (documentation, build failure, &c.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants