Differences between AGCM.rc.tmpl in 5_27_1 @GEOSgcm_App version and in the latest version of @GEOSgcm_App

[bena-nasa]

Proactive note to remember an issue needed to be addressed as we move the model version forward from the initial 5_27_1 version.
There are inconsistencies between the version of the @GEOSgcm_App repo in initial 5_27_1 GEOSadas tag on git vs the latest version of the @GEOSgcm_App.
For example in the 5_27_1 tag AGMC.rc.tmpl has this for the ocean grid specification:

>>>COUPLED<<<      OGCM_NX: @OGCM_NX
>>>COUPLED<<<      OGCM_NY: @OGCM_NY
      OGCM_IM: @OGCM_IM
      OGCM_JM: @OGCM_JM
      OGCM_LM: @OGCM_LM
OGCM_GRIDNAME: @OGCM_GRIDNAME

      OGCM.GRID_TYPE: @OGCM_GRID_TYPE
      OGCM.GRIDNAME: @OGCM_GRIDNAME
      OGCM.IM_WORLD: @OGCM_IM
      OGCM.JM_WORLD: @OGCM_JM
      OGCM.LM: @OGCM_LM

      OGCM.POLE: 'PE'
      OGCM.DATELINE: 'DE'
      OGCM.NF: @OGCM_NF

>>>COUPLED<<<OGCM_GRIDSPEC: @OGCM_GRIDSPEC

whereas in the latest version of @GEOSgcm_App AGCM.rc.tmpl looks like this:

# Ocean Model Configuration Parameters
# ------------------------------------
      OGCM.GRID_TYPE: @OGCM_GRID_TYPE
      OGCM.GRIDNAME: @OGCM_GRIDNAME
      OGCM.IM_WORLD: @OGCM_IM
      OGCM.JM_WORLD: @OGCM_JM
      OGCM.LM: @OGCM_LM
      >>>COUPLED<<<OGCM.NX: @OGCM_NX
      >>>COUPLED<<<OGCM.NY: @OGCM_NY
      >>>COUPLED<<<OGCM.GRIDSPEC: MAPL_Tripolar.nc

      >>>DATAOCEAN<<<>>>LATLON_OGCM<<<OGCM.POLE: 'PE'
      >>>DATAOCEAN<<<>>>LATLON_OGCM<<<OGCM.DATELINE: 'DE'
      >>>DATAOCEAN<<<>>>CUBE_OGCM<<<OGCM.NF: @OGCM_NF

In particular the DATAOCEAN chevron stuff causes these not to be evaluated causing the model to fail.

[sanAkel]

@bena-nasa and @GEOS-ESM/adas-gatekeepers

Reg the ocean, not sure why MOM6 isn't in adas-components.yaml.

From:

• GEOSadas/components.yaml

  Lines 52 to 57 in b58a129

  	GEOSgcm_GridComp:
  	local: ./src/Components/@GEOSgcm_GridComp
  	remote: ../GEOSgcm_GridComp.git
  	tag: cvs/GEOSadas-5_27_1_p2
  	sparse: ./config/GEOSgcm_GridComp.sparse
  	develop: develop

And looking at the corresponding GCM GC:

• https://github.com/GEOS-ESM/GEOSgcm_GridComp/blob/75e253f2a761211ab24279632eaa29696349a79b/GEOSogcm_GridComp/GEOSocean_GridComp/GuestOcean_GridComp/GuestOcean_GridComp.F90#L14-L16

Seems okay to add:
https://github.com/GEOS-ESM/GEOSgcm/blob/90e02ba0fe54b57fdbe8e6f42215743b9b3de987/components.yaml#L79-L84

Or will it be added anyway sometime when: adas-components.yaml and gcm-components.yaml eventually sync up?

[mathomp4]

@sanAkel It is not in the ADAS components.yaml because of multiple reasons:

1. (Main reason) MOM6 is not in the CVS GEOSadas-5_27_1_p3 tag. Our mandate was to get that CVS tag into Git. So that is what's there, essentially. MOM5 was there, MOM6 wasn't.
2. It can't actually be added simply since the Guest CMake for the tag thinks MOM6 is a stub: https://github.com/GEOS-ESM/GEOSgcm_GridComp/blob/75e253f2a761211ab24279632eaa29696349a79b/GEOSogcm_GridComp/GEOSocean_GridComp/GuestOcean_GridComp/CMakeLists.txt
3. If we did add it, we'd need a new branch because the ADAS is too old and still refers to MAPL_Base in many places in CMake. That needs to be MAPL now and @bena-nasa and I can regale you for hours on the fun that causes.

The answer in the end is that our next task is to try and move the ADAS to a point where it is "parallel" to GEOSgcm in Git. At that point, MOM6 will come along since the ADAS should be a "superset" of the GCM.

[sanAkel]

thanks @mathomp4 I get it.

The answer in the end is that our next task is to try and move the ADAS to a point where it is "parallel" to GEOSgcm in Git. At that point, MOM6 will come along since the ADAS should be a "superset" of the GCM.

Reg the "superset" of the GCM. would it be possible to add 2 components.yaml as in:

so someone could have adas_components.yaml?

GEOSana_GridComp:
...
and whatever else adas needs, on top of gcm

gcm_components.yaml as is 

[mathomp4]

@sanAkel Well, the hope is that in the future, the components.yaml in GEOSadas will essentially be the same as the components.yaml in the GEOSgcm in terms of versions, etc. Just the GEOSadas one will have some extra repos (g5pert, GEOSana_GridComp, etc.)