-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/aoloso/hybrid 012924 #269
Open
aoloso
wants to merge
12
commits into
develop
Choose a base branch
from
feature/aoloso/hybrid_012924
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…CoarseDynCore_GridCompMod.F90 to DynCore_GridCompMod.F90. CoarseFVdycoreCubed_GridCompMod.F90 contains code much similar to the original DynCore_GridCompMod.F90. This renaming makes it easier to manage development with git
aoloso
added
the
0 diff structural
Structural changes to repository that are zero-diff
label
Jan 30, 2024
tclune
previously approved these changes
Jan 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cmake changes ok
I have pushed fixes that allow gfortran to run with one thread and produce zero-diff with baseline. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to make the Dyncore of the mixed hybrid code mainstream.
The code is functionally the same as the develop branch but structurally different. It contains extra files for the plumbing of the mixed hybrid code.
It is important to note that the present DynCore_GridCompMod.F90 is now represented by two files, one still called DynCore_GridCompMod.F90 but contains the guts of the coarse decomposition. Other than the SetServices routine, this file closely aligns with the present DynCore_GridCompMod.F90 but with extra lines of code for data exchanges between the two decompositions. The second file, now called FVdycoreCubed_GridCompMod.F90 is a thin wrapper and the link between coarse decomposition and GEOS_SuperdynGridComp.F90.