Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/aoloso/hybrid 012924 #269

Open
wants to merge 12 commits into
base: develop
Choose a base branch
from
Open

Conversation

aoloso
Copy link
Contributor

@aoloso aoloso commented Jan 30, 2024

This is to make the Dyncore of the mixed hybrid code mainstream.

The code is functionally the same as the develop branch but structurally different. It contains extra files for the plumbing of the mixed hybrid code.

It is important to note that the present DynCore_GridCompMod.F90 is now represented by two files, one still called DynCore_GridCompMod.F90 but contains the guts of the coarse decomposition. Other than the SetServices routine, this file closely aligns with the present DynCore_GridCompMod.F90 but with extra lines of code for data exchanges between the two decompositions. The second file, now called FVdycoreCubed_GridCompMod.F90 is a thin wrapper and the link between coarse decomposition and GEOS_SuperdynGridComp.F90.

…CoarseDynCore_GridCompMod.F90 to DynCore_GridCompMod.F90. CoarseFVdycoreCubed_GridCompMod.F90 contains code much similar to the original DynCore_GridCompMod.F90. This renaming makes it easier to manage development with git
@aoloso aoloso added the 0 diff structural Structural changes to repository that are zero-diff label Jan 30, 2024
@aoloso aoloso requested a review from a team as a code owner January 30, 2024 17:26
@aoloso aoloso requested a review from a team as a code owner January 30, 2024 17:26
tclune
tclune previously approved these changes Jan 30, 2024
Copy link
Collaborator

@tclune tclune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cmake changes ok

@aoloso
Copy link
Contributor Author

aoloso commented Mar 19, 2024

I have pushed fixes that allow gfortran to run with one thread and produce zero-diff with baseline.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 diff structural Structural changes to repository that are zero-diff
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants