Auth documentation and Issuer claim #373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
including using docker to install composer deps
add OpenID Connect (OIDC) and OAuth 2.0
mnigh
reviewed
Aug 27, 2021
There was a problem hiding this comment.
Looks good to me. I've changed a few things in the README files, including merging some of @tristan-orourke and @JoshBeveridge documentation for the root README.
tristan-orourke
commented
Aug 30, 2021
README.md
Outdated
Comment on lines
20
to
21
| - [PHP 7.4](https://www.php.net/downloads) | ||
| - [Composer](https://getcomposer.org/) |
There was a problem hiding this comment.
Technically you can actually avoid installing these by using Docker.
There was a problem hiding this comment.
Indeed, this ties in a bit to the discussion about Docker-only instructions or not.
yonikid15
approved these changes
Sep 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #280.
I was originally trying to configure Laravel Passport to be more in line with OpenIDConnect (instead of only Oauth2). Things like the id token + access token, and an introspection endpoint. However, I realized over time that it would a lot of work (I couldn't find a good package that did what I wanted, including working with Laravel Passport) and isn't really required for our current use case.
For now, I added more documentation which should be helpful to anyone else on the team working on Authentication.
I also was able to override the generation of access tokens. (This thread and this code were my main references.) For now the only difference with my custom access token is that it includes the Issuer claim (iss), an extremely common component to OAuth tokens (and required for OIDC).