Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: Game7Token to just ERC20 #13

Merged
merged 6 commits into from
Jun 21, 2024
Merged

Conversation

karacurt
Copy link
Contributor

@karacurt karacurt commented Jun 20, 2024

  • Refactor Game7Token to ERC20
  • Updates ERC20 implementation to take name, symbol and decimals as constructor arguments

Deployment:
Ethereum Sepolia - https://sepolia.etherscan.io/address/0x040Cf7Ee9752936d8d280062a447eB53808EBc08
Arbitrum Sepolia - https://sepolia.arbiscan.io/address/0xb81eb2255be18a31db275eb1fef17286e2a28791

`make` was failing to build on case-sensitive filesystem. This was
because the `Makefile` assumed that the ERC20 contract was in
`web3/contracts/Token`, when it is really in `web3/contracts/token`.

This error could not be detected easily on a modern Mac because they
have case insensitive filesystems.
Copy link
Contributor

@zomglings zomglings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@karacurt : Can you please approve this PR?

#14

It fixes the Makefile in your branch. The PR is into this branch.

chainprof/accounts.go Show resolved Hide resolved
Updated makefile to correctly find ERC20 build artifacts
@karacurt karacurt changed the title Fix: Refactor Game7Token to just ERC20 Refactor: Refactor Game7Token to just ERC20 Jun 21, 2024
@karacurt karacurt changed the title Refactor: Refactor Game7Token to just ERC20 Refactor: Game7Token to just ERC20 Jun 21, 2024
@karacurt karacurt requested a review from zomglings June 21, 2024 14:38
Copy link
Contributor

@zomglings zomglings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@karacurt karacurt merged commit 5de0c8f into main Jun 21, 2024
1 check passed
@karacurt karacurt deleted the feat/erc20-testnet-deploy branch June 21, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants