Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: only run release workflow if tests pass #1769

Draft
wants to merge 13 commits into
base: master
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .changeset/ninety-garlics-tell.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
---
---
8 changes: 5 additions & 3 deletions .github/workflows/release.yaml
Original file line number Diff line number Diff line change
@@ -1,15 +1,17 @@
name: "Release"

on:
push:
branches:
- master
workflow_run:
workflows: "Test"
Dhaiwat10 marked this conversation as resolved.
Show resolved Hide resolved
types: completed
branches: master

concurrency: ${{ github.workflow }}-${{ github.ref }}

jobs:
release:
name: "Release"
if: ${{ github.event.workflow_run.conclusion == 'success'}}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Warning

[note to self]: Ideally we should not merge this before addressing:

runs-on: ubuntu-latest
permissions: write-all
environment:
Expand Down
Loading