Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Doctrine DBAL 3 support #54

Conversation

ihortymoshenko
Copy link
Contributor

Hello!

I added support for Doctrine DBAL 3 and leave support only for PHP 8 in this pull request.

I propose to merge these changes to master and make a new major version.

If you have any questions, let's discuss

@ihortymoshenko ihortymoshenko force-pushed the feature/doctrine-dbal-3-support branch 2 times, most recently from ff297d0 to 1990f82 Compare November 11, 2022 14:50
@tarjei
Copy link

tarjei commented Nov 22, 2022

Any chance this gets merged?

@bakl
Copy link

bakl commented Dec 6, 2022

Any chance this gets merged?

+++

@lionser
Copy link

lionser commented Dec 7, 2022

It is a good chnages, i will wait for marge it. Thanks.

@russelomua
Copy link

I think better leave compatibility with php 7 and dbal ^2.13. Good if your project is progressive and used a cutting edge technologies, but library must corers to most of users.
p.s. i use an php 8.1 and want to update project to dbal ^3

@ihortymoshenko
Copy link
Contributor Author

@russelomua,

the latest version of this bundle supports PHP 7 and Doctrine DBAL 2, so users should have no issues.

PHP 7 is no longer supported (https://www.php.net/supported-versions.php). There aren't even any security fixes.

We should go ahead and start using PHP 8 and Doctrine DBAL 3

@russelomua
Copy link

russelomua commented Dec 27, 2022

Yep, you totally right, in perfect world it is. But in reality we still have a lot of projects running by php7+ even 5.6 :) My point in if you cud leave support - leave it. Lib owners?

@ihortymoshenko
Copy link
Contributor Author

@russelomua,

you can continue to use this bundle with PHP 7 & Doctrine DBAL 2, this PR is about something else

@Nicc0
Copy link

Nicc0 commented Mar 17, 2023

It is a good chnages, i will wait for marge it. Thanks.

What about it?

@amadeuszxd
Copy link

amadeuszxd commented Mar 17, 2023

What about it?

+++

@russelomua
Copy link

Maintainers, please. It's time :)

@asanikovich
Copy link
Member

We will take it in about 2 weeks.

@russelomua
Copy link

russelomua commented Jul 19, 2023

@ihortymoshenko, need to fix README.md because you rename ArrayStringType to ArrayStringableType

# app/config/config.yml
doctrine:
    dbal:
        connections:
        ...
        types:
            ...
            array(string): FOD\DBALClickHouse\Types\ArrayStringType

@russelomua
Copy link

We will take it in about 2 weeks.

any updates?

@ihortymoshenko
Copy link
Contributor Author

@ihortymoshenko, need to fix README.md because you rename ArrayStringType to ArrayStringableType

# app/config/config.yml
doctrine:
    dbal:
        connections:
        ...
        types:
            ...
            array(string): FOD\DBALClickHouse\Types\ArrayStringType

Fixed

@asanikovich asanikovich merged commit 9a2b0dd into FriendsOfDoctrine:master Sep 13, 2023
3 checks passed
@asanikovich
Copy link
Member

We made it. Thank you @ihortymoshenko

Version https://github.com/FriendsOfDoctrine/dbal-clickhouse/releases/tag/v2.0.0 ready for you.

This was referenced Sep 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants