-
-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Doctrine DBAL 3 support #54
Added Doctrine DBAL 3 support #54
Conversation
ff297d0
to
1990f82
Compare
1990f82
to
e986ae1
Compare
Any chance this gets merged? |
+++ |
It is a good chnages, i will wait for marge it. Thanks. |
I think better leave compatibility with |
the latest version of this bundle supports PHP 7 and Doctrine DBAL 2, so users should have no issues. PHP 7 is no longer supported (https://www.php.net/supported-versions.php). There aren't even any security fixes. We should go ahead and start using PHP 8 and Doctrine DBAL 3 |
Yep, you totally right, in perfect world it is. But in reality we still have a lot of projects running by php7+ even 5.6 :) My point in if you cud leave support - leave it. Lib owners? |
you can continue to use this bundle with PHP 7 & Doctrine DBAL 2, this PR is about something else |
What about it? |
+++ |
Maintainers, please. It's time :) |
We will take it in about 2 weeks. |
@ihortymoshenko, need to fix README.md because you rename # app/config/config.yml
doctrine:
dbal:
connections:
...
types:
...
array(string): FOD\DBALClickHouse\Types\ArrayStringType |
any updates? |
Fixed |
We made it. Thank you @ihortymoshenko Version https://github.com/FriendsOfDoctrine/dbal-clickhouse/releases/tag/v2.0.0 ready for you. |
Hello!
I added support for Doctrine DBAL 3 and leave support only for PHP 8 in this pull request.
I propose to merge these changes to master and make a new major version.
If you have any questions, let's discuss