fix a problem with preg_replace parameters in the query #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If one of parameters have a `?` symbol in the text, `preg_replace` can work incorrectly, because just looking for any `?` symbol
argayash
reviewed
Feb 27, 2019
| @@ -292,8 +292,8 @@ public function execute($params = null) : bool | |||
| } else { | |||
| foreach (array_keys($this->values) as $key) { | |||
| $sql = preg_replace( | |||
| '/(' . (is_int($key) ? '\?' : ':' . $key) . ')/i', | |||
| $this->getTypedParam($key), | |||
| '/(' . (is_int($key) ? '\?([,\)])' : ':' . $key) . ')/i', | |||
There was a problem hiding this comment.
what do you think about this expr: \?([,\)]|\s,|\s\)) for resolve next case with whitespace character: '? , ? ) ?
There was a problem hiding this comment.
I haven't seen this situation, but yes, we can add just spaces
Suggested change
| '/(' . (is_int($key) ? '\?([,\)])' : ':' . $key) . ')/i', | |
| '/(' . (is_int($key) ? '\?(\s?[,\)])' : ':' . $key) . ')/i', |
There was a problem hiding this comment.
Anyway, it don't help if we will have ?, in the text :)
|
Seems you have a solution in the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If one of parameters have a
?symbol in the text,preg_replacecan work incorrectly, because just looking for any?symbol