Upgrade Abolished's Third Ability: Bonfire Spring #2658
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@Luffy117 I've tested this and it's not quite working. Ability seems to have a range of 2 (instead of 3) and it remains like that, no matter what). |
|
That's odd because the code is running fine on my end, it's exactly what you'd expect, let me see if I'm committing the wrong code. |
|
@Luffy117 Works overall pretty well now. I've found a small bug though: if delaying Abolished and still not using the ability within current round, there's no range increase in the next round 🐻 |
|
@Luffy117 Also, it would be good to make little comments on those game.ts additions just for the sake of clearing out some confusion if someone looks into the code and is rather clueless about what's happening 🐻 wish that stuff was more generic and have Abolished.ts customize some class from game.ts rather. |
At the end of the turn check if Abolished has used his third skill, if not and the skill has been upgraded he gains extra movement distance.
|
@DreadKnight I moved the determination step to the end stage, which should solve the problem, also added comments. Please check it, thx! |
|
@Luffy117 Needs one more comment imo and should be good for merging after, started a review thingy to point out. |
|
@DreadKnight I added comments to game.ts as well as where I changed it in create.ts and it should work now. |
|
@Luffy117 Alright, merging. Boosted bounty -> https://www.mintme.com/explorer/tx/0x7ff79983502634864be6564fc8d62ca614eb47728a071e160ba087d66d69e5ca 🪙 Tweaked that comment a bit 🐻 I've created that new issue that I've discovered recently #2659 . Feel free to poke at it or any other one. |
|
This fixes #2645 |
|
Thank you, it was a pleasure working with you. |
|
@Luffy117 Likewise 👍🏻 Not many people dare to poke at dealing with the unit abilities 🐻 |
This fixes issue #2645
My wallet address is 0x926A237737E3374801e56b059F18AD554CA22228