-
-
Notifications
You must be signed in to change notification settings - Fork 594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
This fixes issue #issue 2651 #2656
base: master
Are you sure you want to change the base?
Conversation
new file to map avatar types to their image paths.
Instead of manually specifying a background-image for each type, the avatar image is assigned using JavaScript and the avatars.json file.
Handles dynamic assignment of avatar images using the avatars.json configuration.
Automatically generates avatars.json at build time by scanning the avatars folder.
Confirms avatars.json is generated correctly and included in the deployed build directory.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Heya! Thanks for the PR. Seems it fails to build. Also, please always ping issues using hashtag and then number: #2651 |
@MathioLucas I've opened a review. "package.json" is the faulty file, very obvious problem there 🐻 |
@MathioLucas PR titles should be more descriptive, something like "auto-generated unit avatar grid at build time" in this case, as even if properly tagging the issue there, it won't be clickable (like it can be in description). Plus it's way more useful when stuff is reviewed and very importantly, when generating the list of changes for a new version release. |
@MathioLucas Hey! Still waiting for a fix on this one 🐻 |
Thanks for the comments! I added the missing closing brace, removed the duplicate section and fix some formatting and comma placements.
There was a duplicate "avatarUrl
Was missing a semicolon
there was a stray 'e' here .then(avatars => { e document.querySelectorAll(".vignette")
small formating changes
Apologies for the long wait! |
@MathioLucas All the avatars in the dash view show black and there are also errors during build process:
|
This fixes issue #issue 2651
a quick summary for file changes and additions
avatars.less
Replaced hardcoded avatar types with a single CSS class using variables.
avatars.json
Updated .typeXX classes to .vignette with a data-type attribute.
avatarLoader.js
Create this new file to dynamically assign avatar images.
Import avatarLoader.js.
To Automate the creation of avatars.json during build time.