fix: add colored hexagon outlines on unit hover [#2242] #2497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hovering an inactive unit now should causes color coded outline hexagons to be displayed on top of the black ones that are filled, to better indicate unit size and hexagons occupied, as well as the player it belongs to Closes FreezingMoon#2242
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@cesardlinx Pretty good overall! Just a small regression: when targeting a lot of abilities (that usually involve area somehow), there's no more colored fill change for the affected hexagons. See for example Abolished's Fiery Claw ability. |
|
@DreadKnight Thank you! Good catch! I didn't notcied that, I think I fixed the issue, now that functionality is working as before as you can see it in the gif
Feel free to reach out if there's anything else! |
|
@cesardlinx That does the job, well done! Bounty sent 🪙 |
|
Cool! Thank you 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added color coded outline hexagons to be displayed on top of the black ones that are filled when hovering an inactive unit, as you can see in the gif below
Closes #2242
My wallet address is 0xb2717FC8dFcc42A75E06A38aa273C0b9F4Cba848