Fc 1785 86 87 93 av #2745
Open
Fc 1785 86 87 93 av #2745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If Verbatim Place of Birth is not the same as the Alternative Place of Birth and records is valid then the Propagate POB action is available. If Notes field is not null, then the Propagate Notes action is available. Added adjustment of total warnings for the CSV file if warnings are accepted.
Fix bug where CSV file replacement file is rejected if new POB validation fields are present. File should should be accepted but new validation fields skipped as long as validation is in progress.
Adjust error message if pob_valid and non_pob_valid included in file but file is not being validated
…fields' button does not display for that record. Once a POB is Propagated for a CSV record the 'Propagate Alternative fields' button does not display for that record.
Initial Coding to include Step 3 (1787)
Updates after clarification of propagation restrictions
…RY, WRY and NRY Update propagation scope so that HAM includes IOW and YRKS includes ERY, WRY and NRY for Whole Collection propagation eligibility
When POB propagated POB is considered VALID on all records in ED/Piece
Adjust number of warning records for the CSV file correctly
Resolve bug where Next/Previous Warning Entry button was showing for the Last/Fiest warning message
Only allowed to propagate Notes if record_valid = true
Jc/250/review links in footer
…freereg feat: update members page
chore: update release notes
Add <br> to end of the propagation warning messages so that thye are correctly picked up by the download CSV file pob_valid and non_pob_valid flags
…e throughout file If record accepted and POB/Notes was propagated - propagate acceptance throughout file
…en propagated Don't offer propagation after an Accept where records have already been propagated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Combined code for latest requirements for 1785, 1786, 1787 and 1793