Sisyphus Touch: Centering the detected platform #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reqrefusion
force-pushed
the
Download_touch
branch
2 times, most recently
from
95394fb
to
e8ddfa3
Compare
[pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci Some size adjustments. Button fixes [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci Button sizes have been restored to their previous state.
Reqrefusion
force-pushed
the
Download_touch
branch
from
7bd1bcd
to
c70face
Compare
|
@yorikvanhavre, What are you thinking. |
|
Honestly I prefer to keep the way it is now. Easier to maintain, easier to make screenshots, etc |
Then reject the pr. It's just a discussion of an idea. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bit of an arbitrary change, in this change the user's platform is detected with javascript. If it is Windows or Linux, the order of the download platforms changes accordingly, if not, it does not. Technically the screenshot does not make any sense, but I am putting it below anyway, if you want to look at it yourself, you can look here.
Screenshots