[17.0][MIG] rma_purchase #515
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AaronHForgeFlow
force-pushed
the
17.0-mig-rma_purchase-good
branch
2 times, most recently
from
50f2880
to
79c27f0
Compare
|
functional tests good so far. Need to investigate failing unit tests and also forward port this: #403 |
AaronHForgeFlow
force-pushed
the
17.0-mig-rma_purchase-good
branch
from
1708fda
to
2ee9d43
Compare
AaronHForgeFlow
force-pushed
the
17.0-mig-rma_purchase-good
branch
from
e2dd4df
to
baa4ede
Compare
|
Pending to include #518 (when merged in 16) |
* fix assignment of moves. * default qty in rma lines. * remove account dependency. * test and flake8 fixes.
… supplier [IMP]Separate menus for customer and supplier operations * Add active field to rma operation * Added tests * Fix travis * Fix create supplier rma from customer rma
* remove unneded copy and ondelete attributes. * simplify action_view methods. * fix rma line supplier view. * fix wizard. * extend README. * minor extra fixes.
This reverts commit 6443a81.
Conflicts: rma_purchase/models/purchase_order_line.py
cherry-pick 2100329
right in v14. Actions that read those records need to use `sudo` to allow non-admin users to be able to use these actions.
…rrect price unit in moves Otherwise the inventory accounting will be completely wrong.
[FIX] rma: rma_custmer_user has no write permissions in partner, so compute method fails. [IMP] rma: use rma user in tests [FIX] rma_account: move_line_id field string [IMP] rma, rma_account, rma_sale, rma_purchase: tests for stock valuation [FIX] account_move_line_rma_order_line: minor lint, make auto-install
OCA was added in the past by mistake only because a misconfiguration in the CI forced OCA as a required author.
Otherwise the anglo saxon entries won't be correct. For example, the Interim (Delivered) account should balance after receiving and triggering a refund on a customer rma.
"line" is an rma.order.line while purchase_line_id is a relation to purchase.order.line.
…lied Without this, some policies are not being copied from the operation selected when creating new rma line from a rma group. In v16 this patch and the usage of such onchange can be removed in favor of (pre)computed stored editable fields for all policies and configuration in the RMA operation.
AaronHForgeFlow
force-pushed
the
17.0-mig-rma_purchase-good
branch
from
baa4ede
to
ee59be2
Compare
AaronHForgeFlow
force-pushed
the
17.0-mig-rma_purchase-good
branch
from
ee59be2
to
3c1c203
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #505
Respected original code & history
Reasons for supersede:
Merge 17.0 was broken after merging and reverting by mistake some pull requests: #483 & #500
History was incorrect showing merge commits within it.
Merge conflicts when trying to manually merge other PRs on top on that one.
Unable to see the changes in the migration commit, making hard for the reviewer to review the code
Sorry for the inconvenience.
https://github.com/ForgeFlow