Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0][REF] rma: change rules to route in warehouse #456

Open
wants to merge 4 commits into
base: 14.0
Choose a base branch
from

Conversation

DavidJForgeFlow
Copy link
Contributor

@DavidJForgeFlow DavidJForgeFlow commented Sep 26, 2023

The stock.rule fields are not used anywhere on rma. It's only usability is automatically setting the rules when setting a new warehouse with a RMA system. However, these rules are created by default in the main warehouse by the data.
I propose to change the rules for routes to keep a good track of the RMA routes in warehouses and avoid duplicates.

@ForgeFlow

@DavidJForgeFlow DavidJForgeFlow changed the title [14.0][REF] rma: remove rma rules from warehouse [14.0][REF] rma: change rules to route in warehouse Sep 27, 2023
@codecov-commenter
Copy link

codecov-commenter commented Sep 27, 2023

Codecov Report

Merging #456 (25b3a45) into 14.0 (fb9af9b) will decrease coverage by 0.02%.
The diff coverage is 73.33%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             14.0     #456      +/-   ##
==========================================
- Coverage   80.67%   80.65%   -0.02%     
==========================================
  Files         156      156              
  Lines        4858     4855       -3     
  Branches      894      892       -2     
==========================================
- Hits         3919     3916       -3     
+ Misses        729      727       -2     
- Partials      210      212       +2     
Files Coverage Δ
rma/tests/test_rma.py 99.56% <100.00%> (-0.44%) ⬇️
rma_account/tests/test_rma_stock_account.py 98.06% <100.00%> (-1.29%) ⬇️
rma/models/stock_warehouse.py 82.05% <69.23%> (+3.22%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb9af9b...25b3a45. Read the comment docs.

Copy link
Contributor

@AaronHForgeFlow AaronHForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good. I have to do more testing. Just a couple of questions.

If I create a new warehouse and mark the opetion "RMA in this Warehouse" the routes are not created. I have to save and then edit and mark the option in order to get them created.

Then, once created, I could not make them work as they are. I created a customer RMA to be received in the RMA location for the new warehouse, but when I tried to create the incoming shipment the system was not able to fin the route, even when I select the new route in the RMA line

@AaronHForgeFlow
Copy link
Contributor

Also, I think the mehtod def _default_routes(self): in rma_operation should be changed so it takes the routes of the default warehouse

Copy link
Contributor

@AaronHForgeFlow AaronHForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working good now merging soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants