-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[14.0][REF] rma: change rules to route in warehouse #456
base: 14.0
Are you sure you want to change the base?
Conversation
8c8c9be
to
f29a816
Compare
f29a816
to
25b3a45
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## 14.0 #456 +/- ##
==========================================
- Coverage 80.67% 80.65% -0.02%
==========================================
Files 156 156
Lines 4858 4855 -3
Branches 894 892 -2
==========================================
- Hits 3919 3916 -3
+ Misses 729 727 -2
- Partials 210 212 +2
Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good. I have to do more testing. Just a couple of questions.
If I create a new warehouse and mark the opetion "RMA in this Warehouse" the routes are not created. I have to save and then edit and mark the option in order to get them created.
Then, once created, I could not make them work as they are. I created a customer RMA to be received in the RMA location for the new warehouse, but when I tried to create the incoming shipment the system was not able to fin the route, even when I select the new route in the RMA line
Also, I think the mehtod def _default_routes(self): in rma_operation should be changed so it takes the routes of the default warehouse |
25b3a45
to
667c87d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Working good now merging soon
667c87d
to
3e70189
Compare
The stock.rule fields are not used anywhere on rma. It's only usability is automatically setting the rules when setting a new warehouse with a RMA system. However, these rules are created by default in the main warehouse by the data.
I propose to change the rules for routes to keep a good track of the RMA routes in warehouses and avoid duplicates.
@ForgeFlow