-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support of projection on get route #1205
Conversation
@@ -30,7 +26,7 @@ export default class GetRoute extends CollectionRoute { | |||
const records = await this.collection.list( | |||
QueryStringParser.parseCaller(context), | |||
filter, | |||
ProjectionFactory.all(this.collection), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why ProjectionFactory.all
doesn't already support projections 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because you are right QueryStringParser.parseProjectionWithPks
alrezady use ProjectionFactory.all
internally when needed..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🫶
Code Climate has analyzed commit dd0bcc2 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (98% is the threshold). This pull request will bring the total coverage in the repository to 97.2%. View more on Code Climate. |
🎉 This PR is included in version 1.12.3 🎉 The release is available on npm package (@latest dist-tag) Your semantic-release bot 📦🚀 |
## [1.11.11](https://github.com/ForestAdmin/agent-nodejs/compare/[email protected]@1.11.11) (2024-11-12) ### Bug Fixes * **forest-cloud:** generate datasource file on bootstrap ([#1203](#1203)) ([3a365f2](3a365f2)) * **typo:** bootstrap command ([#1206](#1206)) ([d60337b](d60337b)) ### Features * add support of projection on get route ([#1205](#1205)) ([5df3c58](5df3c58)) * **forest-cloud:** introduce local development environment for cloud projects ([#1199](#1199)) ([e1cfa42](e1cfa42))
# [1.53.0](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/[email protected]...@forestadmin/[email protected]) (2024-11-12) ### Bug Fixes * **forest-cloud:** generate datasource file on bootstrap ([#1203](#1203)) ([3a365f2](3a365f2)) * **typo:** bootstrap command ([#1206](#1206)) ([d60337b](d60337b)) ### Features * add support of projection on get route ([#1205](#1205)) ([5df3c58](5df3c58)) * **forest-cloud:** introduce local development environment for cloud projects ([#1199](#1199)) ([e1cfa42](e1cfa42))
🎉 This PR is included in version 1.11.11 🎉 The release is available on Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 1.53.0 🎉 The release is available on npm package (@latest dist-tag) Your semantic-release bot 📦🚀 |
# [1.35.0](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/[email protected]...@forestadmin/[email protected]) (2024-11-15) ### Bug Fixes * **advanced-export:** export now uses context.filter ([#1198](#1198)) ([68cef9b](68cef9b)) * change error message when mixing pages and other elements in an action form ([#1201](#1201)) ([c06e8f7](c06e8f7)) * **forest-cloud:** generate datasource file on bootstrap ([#1203](#1203)) ([3a365f2](3a365f2)) * ignore inconsistent foreign key types ([#1202](#1202)) ([b5e8c6a](b5e8c6a)) * **typo:** bootstrap command ([#1206](#1206)) ([d60337b](d60337b)) ### Features * add support of projection on get route ([#1205](#1205)) ([5df3c58](5df3c58)) * better logs during timeout ([#1208](#1208)) ([e844184](e844184)) * **capabilities:** register capabilities route for field filter operators ([#1197](#1197)) ([31edc82](31edc82)) * **forest-cloud:** introduce local development environment for cloud projects ([#1199](#1199)) ([e1cfa42](e1cfa42))
🎉 This PR is included in version 1.35.0 🎉 The release is available on npm package (@latest dist-tag) Your semantic-release bot 📦🚀 |
Definition of Done
General
Security