Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an import from ChainRules macro #168

Merged
merged 3 commits into from
Apr 19, 2024

Conversation

avik-pal
Copy link
Member

@avik-pal avik-pal commented Apr 15, 2024

Adds a macro to import rrules from ChainRules.

Fixes #132

PR Checklist

  • Tests are added
  • Documentation, if applicable

(can't seem to request reviewers directly)

cc @ToucheSir

@coveralls
Copy link

coveralls commented Apr 15, 2024

Pull Request Test Coverage Report for Build 8739734069

Details

  • 51 of 52 (98.08%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+2.4%) to 75.532%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/macros.jl 51 52 98.08%
Totals Coverage Status
Change from base Build 8369014015: 2.4%
Covered Lines: 568
Relevant Lines: 752

💛 - Coveralls

@avik-pal avik-pal marked this pull request as ready for review April 15, 2024 20:49
test/chainrules.jl Outdated Show resolved Hide resolved
Copy link
Member

@oxinabox oxinabox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merge once happy you have addressed these

Project.toml Outdated Show resolved Hide resolved
@avik-pal
Copy link
Member Author

@oxinabox you will have to merge, I don't have merge rights

@ChrisRackauckas ChrisRackauckas merged commit e384881 into FluxML:master Apr 19, 2024
4 checks passed
@avik-pal avik-pal deleted the ap/crc_macro branch April 19, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ChainRules import mechanism
5 participants