-
-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a readme #130
Add a readme #130
Conversation
Co-authored-by: Brian Chen <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to me overall, though others may have thoughts.
Maybe it ought to have a "limitations" section? Mentioning that array mutation is unsupported... and that the more your model looks like a simple Flux model the better hope you have? Not sure. |
I was under the impression that limited mutation was supported as it is in PyTorch, is that not the case? Either way, IMO a limitations section seems more useful iff. we can come up with some concrete examples of said limitations. |
Oh I messed up my example. Some do work, via TrackedReal, some don't: julia> Tracker.gradient([1,2,3]) do x
y = ones(eltype(x), 2)
y[1] = x[end]^2
sum(y)
end
([0.0, 0.0, 6.0] (tracked),)
julia> Tracker.gradient([1,2,3]) do x # works under ReverseDiff
y = fill!(similar(x), 0)
y[1] = x[end]^2
sum(y)
end
ERROR: MethodError: no method matching Float64(::Tracker.TrackedReal{Float64})
[2] setindex!(A::Vector{Float64}, x::Tracker.TrackedReal{Float64}, i1::Int64)
@ Base ./array.jl:957
julia> Tracker.gradient([1,2,3]) do x # fails with ReverseDiff too
x[1] = x[3]^3
sum(x)
end
ERROR: Can't differentiate `setindex!` |
We can adjust later, maybe this is a start at least... |
Pull Request Test Coverage Report for Build 2900404559Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
No description provided.