comments etc.

FluxML · Dec 14, 2023 · a5214a4 · a5214a4
1 parent 09e9551
commit a5214a4
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/benchmarking/benchmark.jl b/benchmarking/benchmark.jl
@@ -49,9 +49,9 @@ modelstrings = (
     "EfficientNetv2(:small)",
     "ConvMixer(:small)",
     "ConvNeXt(:small)",
-    # "MLPMixer()", # found no tests
-    # "ResMLP()", # found no tests
-    # "gMLP()", # found no tests
+    # "MLPMixer()", # no tests found
+    # "ResMLP()", # no tests found
+    # "gMLP()", # no tests found
     "ViT(:tiny)",
     "UNet()"
     )
@@ -60,6 +60,7 @@ for (i, modstring) in enumerate(modelstrings)
     @timeit to "$modstring" begin
         @info "Evaluating $i/$(length(modelstrings)) $modstring"
         @timeit to "First Load" eval(Meta.parse(modstring))
+        # second load simulates what might be possible with a proper set-up pkgimage workload
         @timeit to "Second Load" model=eval(Meta.parse(modstring))
         @timeit to "Training" train(model,
             train_loader,

diff --git a/benchmarking/tooling.jl b/benchmarking/tooling.jl
@@ -93,10 +93,10 @@ function train(args...;kwargs...)
     try
         _train(args...; kwargs...)
     catch ex
-        rethrow()
+        # rethrow()
         println()
         @error sprint(showerror, ex)
         GC.gc()
         return false
     end
-end
+end