-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add docstrings! #209
Add docstrings! #209
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #209 +/- ##
==========================================
+ Coverage 92.27% 93.03% +0.75%
==========================================
Files 9 9
Lines 246 244 -2
==========================================
Hits 227 227
+ Misses 19 17 -2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work. You have erred on the verbose side, which has made it easier to review 😉 . Please make the cuts suggested in annotations. Some of these could go into separate MLJFlux documentation (replacing current readme) but we'll need to come back to that later.
It's very nice to have the builder illustrations. One comment: I think we could use the macro for all of them, to save defining extra structs. In some models (classifiers?) you are still using the explicit definitions. And be sure to test all examples. They should be self-contained.
Thanks @josephsdavid for your valuable contribution. 🎆 |
With code cleaned up and (hopefully) working CI!