FEATURE: Adds validation for create tag dialog #241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markusguenther
changed the title
markusguenther
force-pushed
the
feature/validation
branch
from
dc2cdc4 to
bc906ce
Compare
|
Improved labels for German translation and rebased to the latest main branch. |
markusguenther
force-pushed
the
feature/validation
branch
2 times, most recently
from
80c06bf to
d259929
Compare
Sebobo
reviewed
Nov 4, 2024
Resources/Private/JavaScript/asset-tags/src/components/CreateTagDialog.tsx
Outdated
Show resolved
Hide resolved
To prevent exceptions and make it more user friedly this change validated the tag creation form, so that you can not create an empty tag or a tag that already exists.
Sebobo
force-pushed
the
feature/validation
branch
from
d259929 to
d66a809
Compare
Sebobo
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To prevent exceptions and make it more user-friendly this change validated the tag creation form so that you cannot create an empty tag or a tag that already exists.
Related to issue #240
New behavior:
flowpack-media-validation.mp4