Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Applications routing follow up #4891

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Applications routing follow up #4891

wants to merge 5 commits into from

Conversation

cstns
Copy link
Contributor

@cstns cstns commented Dec 9, 2024

Description

  • add a back button to the app instance creation page
  • replace device group infocard with custom component which does not miss align with the page header
  • add multiple breadcrumb entries for the device group page
  • alter back button from the team creation page after altering backTo binding

Related Issue(s)

part of #4836

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Includes a DB migration? -> add the area:migration label

- add a back button to the app instance creation page
- replace device group infocard with custom component which does not miss align with the page header
- add multiple breadcrumb entries for the device group page
Copy link

codecov bot commented Dec 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.44%. Comparing base (cf9bfbe) to head (e381da0).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4891   +/-   ##
=======================================
  Coverage   78.44%   78.44%           
=======================================
  Files         325      325           
  Lines       15353    15353           
  Branches     3529     3529           
=======================================
  Hits        12043    12043           
  Misses       3310     3310           
Flag Coverage Δ
backend 78.44% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cstns cstns self-assigned this Dec 10, 2024
Base automatically changed from fix-application-child-routes-not-making-the-applications-nav-menu-active to main December 18, 2024 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant