Clean definition of range types #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FlorianWendelborn
force-pushed
the
clean-definition-of-range-types
branch
from
25a9126
to
a3b3595
Compare
|
@Isokaeder thanks for the PR, I rebased this and got rid of yarn2 (in favor of https://bun.sh). LGTM now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use recursive type to generate a cleaner expresseion for
UInt4andUInt8This needs update of typescript to take advantage of this performance improvement (4.5) for recursive types.
Note that I have no clue what I am doing regarding yarn@2 - I tried to conservatively update typescript to 4.5.5 but yarn insisted on installing 4.9.5, not sure how to convince it otherwise