Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: fix prettier ci issues #4932

Merged
merged 6 commits into from
Dec 20, 2024
Merged

ci: fix prettier ci issues #4932

merged 6 commits into from
Dec 20, 2024

Conversation

matthewelwell
Copy link
Contributor

@matthewelwell matthewelwell commented Dec 19, 2024 •
edited
Loading

Changes

  • Add ignore records for python and image files.
  • Move remaining exclusions from pre-commit to prettier config

How did you test this code?

I have run prettier run --all-files locally and I have also tested these changes against the changes in #4928 (by cherry picking them across to this branch, then reverting) which seem to be the ones bringing out the issue we're trying to solve.

@vercel Vercel
Copy link

vercel bot commented Dec 19, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 20, 2024 0:01am
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
flagsmith-frontend-preview ⬜️ Ignored (Inspect) Visit Preview Dec 20, 2024 0:01am
flagsmith-frontend-staging ⬜️ Ignored (Inspect) Visit Preview Dec 20, 2024 0:01am

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 19, 2024 •
edited
Loading

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-e2e:pr-4932 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api-test:pr-4932 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-4932 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith:pr-4932 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-private-cloud:pr-4932 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-frontend:pr-4932 Finished ✅ Results ✅

@github-actions github-actions bot added the ci-cd Build, test and deployment related label Dec 19, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 19, 2024 •
edited
Loading

Uffizzi Preview deployment-59250 was deleted.

@github-actions github-actions bot added ci-cd Build, test and deployment related and removed ci-cd Build, test and deployment related labels Dec 19, 2024
@matthewelwell matthewelwell requested a review from khvn26 December 19, 2024 15:33
matthewelwell
matthewelwell commented Dec 19, 2024
View reviewed changes
.prettierignore Outdated Show resolved Hide resolved
@matthewelwell matthewelwell marked this pull request as draft December 20, 2024 11:03
@github-actions github-actions bot added ci-cd Build, test and deployment related and removed ci-cd Build, test and deployment related labels Dec 20, 2024
@github-actions github-actions bot added ci-cd Build, test and deployment related and removed ci-cd Build, test and deployment related labels Dec 20, 2024
@github-actions github-actions bot added ci-cd Build, test and deployment related and removed ci-cd Build, test and deployment related labels Dec 20, 2024
@github-actions github-actions bot added ci-cd Build, test and deployment related docs Documentation updates and removed ci-cd Build, test and deployment related docs Documentation updates labels Dec 20, 2024
@matthewelwell matthewelwell force-pushed the ci/exclude-more-prettier-files branch from 31bb7a5 to d865416 Compare December 20, 2024 12:04
@github-actions github-actions bot removed the ci-cd Build, test and deployment related label Dec 20, 2024
@github-actions github-actions bot added the ci-cd Build, test and deployment related label Dec 20, 2024
@matthewelwell matthewelwell marked this pull request as ready for review December 20, 2024 12:06
@github-actions github-actions bot added ci-cd Build, test and deployment related and removed ci-cd Build, test and deployment related labels Dec 20, 2024
@matthewelwell matthewelwell merged commit b60af94 into main Dec 20, 2024
71 checks passed
@matthewelwell matthewelwell deleted the ci/exclude-more-prettier-files branch December 20, 2024 12:20
@matthewelwell matthewelwell mentioned this pull request Dec 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khvn26 khvn26 khvn26 approved these changes

Assignees
No one assigned
Labels
ci-cd Build, test and deployment related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matthewelwell @khvn26