Fix for websocket server reading Sec-WebSocket-Key in wrong place when missing, and handling common mistakes from clients #17
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#12
This is a fix for SimpleWebTransport attempting to read the websocket handshake key
"Sec-WebSocket-Key: "
from the response headers, butSec-Websocket-Key
instead ofSec-WebSocket-Key
).Websocket
-
gr: I can't remember off hand which is the correct case, but that's a little irrelevent when established servers & clients send the wrong things
-1 + offset
, which is obviously wrong. (could read out of bounds & throw, could just read garbage)