Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove unecessary token #111

Merged
merged 1 commit into from
Jul 3, 2024
Merged

remove unecessary token #111

merged 1 commit into from
Jul 3, 2024

Conversation

frshwtr
Copy link
Contributor

@frshwtr frshwtr commented Jul 2, 2024

No description provided.

@frshwtr frshwtr requested a review from a team as a code owner July 2, 2024 15:45
@github-actions github-actions bot added the library Relates to an Origami library label Jul 2, 2024
notlee
notlee approved these changes Jul 2, 2024
View reviewed changes
Copy link
Contributor

@notlee notlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you confident this will work? Since the last release attempt failed, should we add a release Github label to this PR as a test?

@frshwtr frshwtr added the breaking Will require a major version bump label Jul 3, 2024
@frshwtr
Copy link
Contributor Author

frshwtr commented Jul 3, 2024

Are you confident this will work? Since the last release attempt failed, should we add a release Github label to this PR as a test?

Yes, express web token had the same issue, [removing the token worked for it also]((https://github.com/Financial-Times/express-web-service/actions/runs/9763394901/job/26949179230).

@frshwtr frshwtr merged commit 4db7009 into master Jul 3, 2024
6 checks passed
@frshwtr frshwtr deleted the remove-token branch July 3, 2024 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@notlee notlee notlee approved these changes

Assignees
No one assigned
Labels
breaking Will require a major version bump library Relates to an Origami library
Projects
Origami ✨
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@frshwtr @notlee