Allow name to deal with floats/ints #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Elixometer and Exometer were generating paths like: ["app_name", "db", "read", 75, "latency"] which wouldn't get munged into a collectd path via the name function
* Remove afunix
|
Sorry for letting this wait for so long. The change looks good, but since it works only with OTP 19 and later, the .travis.yml file should be updated as well. ... Of course, there are no failing tests, since there are no tests, period. Still, one might interpret the current .travis.yml file as an indication of which OTP versions are supported. |
* So we can do what we want. Like removing this annoying log message
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
["app_name", "db", "read", 75, "latency"]
which wouldn't get munged into a collectd path via
the name function