-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CellMultiValues (new attempt) #872
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #872 +/- ##
==========================================
+ Coverage 93.30% 93.33% +0.02%
==========================================
Files 36 36
Lines 5257 5308 +51
==========================================
+ Hits 4905 4954 +49
- Misses 352 354 +2 ☔ View full report in Codecov by Sentry. |
I've renamed to Otherwise, ready for review from my side if anyone wants to take a look! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some comments.
Since I am struggling recently with the question: Do you think this should be still Ferrite core or in some package on top?
I think this belongs in Ferrite core for two main reasons:
But of course, this is my biased opinion :) |
Co-authored-by: Dennis Ogiermann <[email protected]>
Supersedes #680 and #674, using the components from #764
A couple of notes on the design
cv::CellMultiValues
,cv[:u]::FunctionValues
, which can be used just like aCellValues
for all function-related queries, but not geometrical such asgetdetJdV
, these are called oncv
itself.FunctionValues
object, saving both memory (bandwidth) and computations in reinit!.FunctionValues
subtypesAbstractValues
to make allfunction_value
and similar work. This implies that e.g.spatial_coordinate(cv[:u]::FunctionValues, args...)
will give a method error ongetngeobasefunctions
instead ofspatial_coordinate
. We could add specializations if easier error messages are required.It would be very convenient to also store the dof_range of each field, but having this as an input would be error-prone if the user provides the wrong order compared to what is stored in the(Edit: not generally applicable, so leave out for now)SubDofHandler
. If a convenience constructor similar to #806 would be used, this would be safe, but that should only be a high-level constructor interface. Ideas are welcome!