Simplify evaluate_at_grid_nodes #1097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1097 +/- ##
==========================================
- Coverage 93.57% 93.57% -0.01%
==========================================
Files 39 39
Lines 6074 6071 -3
==========================================
- Hits 5684 5681 -3
Misses 390 390 ☔ View full report in Codecov by Sentry. |
KnutAM
reviewed
Oct 29, 2024
KnutAM
reviewed
Oct 30, 2024
lijas
force-pushed
the
simplify_export
branch
from
f831eed
to
0972061
Compare
Co-authored-by: Knut Andreas Meyer <[email protected]>
lijas
force-pushed
the
simplify_export
branch
from
0972061
to
cd9812f
Compare
KnutAM
approved these changes
Nov 5, 2024
|
Yes, the vtk output looks correct (checked manually). And we have tests that check if the hash of vtk-files changes, right? |
True, I wasn't sure if the writing of solution was covered by those, but seems so! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were some hacks in
evaluate_at_grid_nodesfor embedded element which I don't think is needed anymore.Also added
shape_value_type(::Interpolation, T)which I think will be required for #958 also.