Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove explicit documention of fields in CellCache #1079

Merged
merged 2 commits into from
Sep 28, 2024

Conversation

KnutAM
Copy link
Member

@KnutAM KnutAM commented Sep 28, 2024

  • Better to use the functions, e.g. getnodes, as these also work with FacetCache.
  • In PRs such as WIP: Add cell to CellCache #1060, not documented increases flexibility of changing representation (when cell is stored, no need to store the nodes)

And clean some leftover comments
Copy link

codecov bot commented Sep 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.71%. Comparing base (4b8c233) to head (a3c2ca1).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1079   +/-   ##
=======================================
  Coverage   93.71%   93.71%           
=======================================
  Files          39       39           
  Lines        6042     6042           
=======================================
  Hits         5662     5662           
  Misses        380      380           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@KnutAM KnutAM marked this pull request as draft September 28, 2024 14:00
@KnutAM KnutAM marked this pull request as ready for review September 28, 2024 14:04
@fredrikekre fredrikekre merged commit 225a016 into master Sep 28, 2024
11 checks passed
@fredrikekre fredrikekre deleted the kam/iterators_doc branch September 28, 2024 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants