Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

animated slider homepage #225

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

animated slider homepage #225

wants to merge 5 commits into from

Conversation

satavshreya
Copy link
Contributor

Description

FIXES #118

Describe the changes you've made

Added animated slider with captions

  • My code follows the code style of this project.
    -->
  • I have added my name in the contributors list at the end of README.md file.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • The title of my pull request is a short description of the requested changes.
  • Open Source Program names GSSOC

@khushishikhu khushishikhu added gssoc21 Issues for GirlSript Summer of Code Level3 New feature, Major Bug fixing labels Apr 24, 2021
@satavshreya
Copy link
Contributor Author

@khushishikhu do let me know

Copy link
Contributor Author

@satavshreya satavshreya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@khushishikhu i have made the changes

<div className={styles.item1}>Women complain about premenstrual syndrome, but I think of it as the only time of the month that I can be myself- Roseanne Barr</div>
<div className={styles.item2}>Periodo is here to help you</div>
<div className={styles.item3}>We Care About Your Periods</div>

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
</div>

@khushishikhu
Copy link
Member

khushishikhu commented Apr 25, 2021

image
@satavshreya I have seen that this scrolling isn't covering up the webpage

@khushishikhu
Copy link
Member

@satavshreya I have an idea if you could implement that. https://codepen.io/Niranjan31/pen/vYXYOZa I have searched out this design for the homepage and would love if you could implement it

@satavshreya
Copy link
Contributor Author

@khushishikhu i will try this out

@satavshreya
Copy link
Contributor Author

satavshreya commented Apr 25, 2021

image
@khushishikhu @Aaishpra i have done this with reference to the link that you gave tell me if any changes please
I didnt keep the text animated Slider because it was changing the horizontal scroll too

@@ -2,13 +2,14 @@
@import url('https://fonts.googleapis.com/css2?family=Satisfy&display=swap');
@import url('https://fonts.googleapis.com/css2?family=Dancing+Script&family=Playball&family=Redressed&family=Special+Elite&display=swap');

.background{
/*.background{
margin: 50px 0;
background-image: url('./images/women.jpg');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

won't commenting this code out make the background image disappear

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Aaishpra i checked there wasnt such change because the picture that is women .jpg in images isnt the background page its some other picture

@Aaishpra
Copy link
Member

@satavshreya can you add screenshots or gif for the changes done here.
thanks

@satavshreya
Copy link
Contributor Author

image
image
@Aaishpra

Copy link
Member

@khushishikhu khushishikhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@satavshreya please remove the merge conflicts. Rest looks good to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc21 Issues for GirlSript Summer of Code hactoberfest-accepted Level3 New feature, Major Bug fixing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automated Slider added in Home
3 participants