Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce contracts to deployable size #41

Merged
merged 39 commits into from
Nov 17, 2023
Merged

Reduce contracts to deployable size #41

merged 39 commits into from
Nov 17, 2023

Conversation

BenSparksCode
Copy link
Contributor

No description provided.

BenSparksCode and others added 30 commits October 26, 2023 19:32
@BenSparksCode
Start refactoring errors to custom errs
8d735ea
@BenSparksCode
Refactor DAppIntegration to custom errors
c77005d
@BenSparksCode
Refactored AtlETH to custom errors
72124b9
@BenSparksCode
Refactor Permit69 to custom errors
96e3299
@BenSparksCode
Refactored SafetyLocks to custom errors
ed7dd00
@BenSparksCode
Refactored GasAcc to custom errors
aec732c
@BenSparksCode
Start planning contract split: AtlETH and Factory
c84168e
@BenSparksCode
Split out Factory to AtlasFactory
6e40e34
@BenSparksCode
More AtlasFactory progress
97d24db
@BenSparksCode
Add code to precompute Factory deploy address
83ec7c2
@BenSparksCode
More AtlasFactory porting and interface added
64a824c
@BenSparksCode
Factory split out to separate contract
bad0344
@BenSparksCode
Fix interface bugs around Atlas vs AtlasFactory in tests
4134f0c
@BenSparksCode
Change split strategy to AtlasVerification over AtlETH
bb004f4
@BenSparksCode
Save progress on splitting out verification
d3fc5f0
@BenSparksCode
Rename verify to verifySolverOp and integrate in Escrow
4563da5
@BenSparksCode
Integrate verifyUser and verifyDApp with split
da4963a
@BenSparksCode
Verification split out and compiling, some tests failing
85ff2a9
@BenSparksCode
More AtlasVerification test and interface fixes
5e2b066
@BenSparksCode
Remove redundant files and code
8c0de2a
@BenSparksCode
Convert string error to custom err
49dc2c9
@BenSparksCode
Fix: Verification checks Atlas address instead of own
75d7407
@BenSparksCode
Fixed testMain - V2Helper needed verification addr
8e84210
@BenSparksCode
Split out all vars and constants to storage contract
fe671a3
@BenSparksCode
Integrate Storage contract for all Atlas vars and constants
6574ad3
@BenSparksCode
Fix Atlas constructor args in tests and deploy script
d70deab
@jj1980a
minor refactor to allow user's nonce to be initialized when creating …
8891514 
…execution environment
@jj1980a
fix Permit69 tests by using custom errors
bdf5c93
@BenSparksCode
Merge pull request #42 from FastLane-Labs/size-cuts-2
3f4ba3e 
Test fixes for size cuts branch
@BenSparksCode
Consolidate Verification interface fns
78e394b
@BenSparksCode BenSparksCode requested review from thogard785, jj1980a and Code0x2 and removed request for thogard785 and jj1980a November 9, 2023 09:22
@BenSparksCode BenSparksCode marked this pull request as ready for review November 9, 2023 09:22
thogard785
thogard785 approved these changes Nov 17, 2023
View reviewed changes
Copy link
Contributor

@thogard785 thogard785 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! Lots of work to do on top of this, but this is a great foundation for the split and i don't see any apparent security issues introduced by the division point.

@BenSparksCode BenSparksCode merged commit 4cc3138 into main Nov 17, 2023
@BenSparksCode BenSparksCode deleted the size-cuts branch November 17, 2023 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jj1980a jj1980a jj1980a approved these changes

@thogard785 thogard785 thogard785 approved these changes

@Code0x2 Code0x2 Awaiting requested review from Code0x2

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BenSparksCode @jj1980a @thogard785