Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: limit fx dialog tabs by parent dialog #1181

Merged
merged 1 commit into from
Aug 26, 2024

Conversation

DSCaskey
Copy link
Contributor

This fixes the fx dialog usable tabs depending on the parent dialog.

If the FX dialog is opened from the Variables table the Tool Variables are removed:

Screenshot 2024-08-20 100751

If the F dialog is opened in SeamlyMe the Custom Variables and the Tool Variables are removed.

Screenshot 2024-08-20 100826

closes issue #1178

Copy link

what-the-diff bot commented Aug 20, 2024

PR Summary 🎉

Great job, team! 🙌 Here's what we've been accomplishing together:

  • Revamped Formula Editor Dialog:
    We have made some enhancements to the EditFormulaDialog constructor. It now accepts an additional parameter called source. This parameter helps it understand where the request is coming from, enabling it to determine which elements need to be visible based on the source. This not only simplifies our process but also strengthens our platform's flexibility and adaptability. 🚀

  • Custom Settings for Each Module:
    We updated functions in the seamly2d, dialogvariables, and seamlyme modules to create a more customized EditFormulaDialog based on their unique requirements. This extra layer of customization in our modules will refine our application's overall user experience. 🌟

  • Expanded Dialog Source Definition:
    We've added an enum value called DialogSource in def.h. This helps us identify the initiating dialog type for 'Edit Formula', crucial to deciding which tabs we should hide. This new level of control allows a smoother and less confusing interaction for our users. 🌐

  • Update on Multiple Dialogs:
    To implement our new feature, we adjusted the instances of EditFormulaDialog in dialogspline.cpp, dialogsplinepath.cpp, intersect_circles_dialog.cpp, intersect_circletangent_dialog.cpp, dialoginternalpath.cpp, PatternPieceDialog.cpp, and vabstracttool.cpp. It's amazing to see our updates swiftly integrated across our different tools, making our application more consistent and intuitive. 😊

Fantastic job, everyone! These updates streamline our workflows, improving our application’s agility. Let’s keep up the great work! 💪 🌈

@slspencer slspencer merged commit 061088e into develop Aug 26, 2024
10 checks passed
@slspencer slspencer deleted the limit-fxdialog-tabs-by-source branch August 26, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: FX Dialog shows all tab options in Variables Table and SeamlyMe
2 participants