Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

icon: Add a bounding box around the icon to match Apple and GNOME guidelines #1163

Closed
wants to merge 1 commit into from

Conversation

csett86
Copy link
Member

@csett86 csett86 commented Aug 5, 2024

Apple has a 6.5% bounding box, taken from https://developer.apple.com/design/resources/

GNOME has a 3% box for round icons (4px/128px), see https://gitlab.gnome.org/Teams/Design/HIG-app-icons/blob/master/template.svg

KDE also has a 3% box (4px/128px), see https://develop.kde.org/hig/icons/colorful/

@csett86 csett86 changed the title icon: Add a 6.5% bounding box around the icon to match apple and GNOME app icon guidelines icon: Add a bounding box around the icon to match Apple and GNOME guidelines Aug 5, 2024
@csett86 csett86 marked this pull request as draft August 5, 2024 17:55
@csett86
Copy link
Member Author

csett86 commented Aug 5, 2024

Still WIP, I need to update the copies in src/libs/vmisc/share/resources/icon as well

@DSCaskey
Copy link
Contributor

DSCaskey commented Aug 6, 2024

Why are we resisizing these icons? Those are application icons not file icons. Your're changing the size of the icon that is used for ex in windows and dialogs:

image

If you want the file icons they're located in Seamly2d/dist

@csett86
Copy link
Member Author

csett86 commented Aug 8, 2024

Thanks @DSCaskey, I also noticed that I got the wrong icons. Sorry for the noise... What I want to achieve: Currently Seamly2D looks "too big" in the macOS task bar, as its filling all the space, while all the other icons are smaller and have a rectangular shape, even natually round ones like the Photos app or Firefox:

Bildschirmfoto 2024-08-08 um 23 20 54

I will redo this and use the places where the mac application icons (Seamly2D and SeamlyMe) are stored, and just start there. Then tackle linux later...

@csett86
Copy link
Member Author

csett86 commented Aug 8, 2024

Continued in #1167

@csett86 csett86 closed this Aug 8, 2024
@csett86 csett86 deleted the icon-bounding-box branch August 8, 2024 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants