Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix qt6 build error #1086

Conversation

marco-langer
Copy link

Closes #1019

@CLAassistant
Copy link

CLAassistant commented Apr 13, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

what-the-diff bot commented Apr 13, 2024

PR Summary 📝

  • Including QObject Library 📘

By adding the QObject Library to our code, we're laying the foundation to make our application better and friendlier for our users. This addition makes it possible for us to keep our code clean and manageable. QObject is instrumental in signal and slot mechanism, which is literally a game-changer. This mechanism adds flexibility to our application by establishing and handling communication between objects, thereby promoting a more interactive and dynamic user experience. Essentially, this means our application can react and evolve based on the user's choices and inputs! 🧡

Copy link
Member

@csett86 csett86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is intended to fix a qt6 build error, the pr needs to target the qt6 branch, not the main develop branch which is still on qt5

Apart from that I dont think that the issue is still present in the qt6 branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build: qt6 - nmake error C3861: 'tr' identifier not found nmake error in ifcdef.cpp
3 participants