qt6(msvc): fix xerces.dll missing when running from Qt Creator #1144

xypp3 · 2024-07-11T11:35:53Z

fix: Qt6 xerces.dll missing

TLDR

Fix issue that caused Qt6 Seamly2D xerces-c_3_2.dll not be be compiled by including it directly in the library folder.

Description

For the last couple of weeks we have been working on understanding the issues that stood in the way of Qt6. We've been in commuincation with Sue (Github username: @slspencer). This PR originates from the "qt6" branch and is intend to be merged back into it.

Problem

This PR fixes issue presented in issue#1018. The issue states that when trying to compile Seamly2D on Windows 10 with MSVC19, the build failed. Screenshot below is taken from issue page:

Fix

The compiled xerces-c_3_2.dll is placed inside the src/libs/xerces/msvc folder. The .dll was taken from the Seamly xerces hosted assets

Demo

Video below shows both Qt6 version of Seamly2D compiling and being able to open files without freezing/crashing:
video demo of fixed Qt6 Seamly2D

Build Environment

TLDR: This was tested on a VM running Windows 10.

For more details on the build environment read the gist linked here

Merge Qt6 branch from main Seamly2D repository

This reverts commit d75d936.

…ngLiteral object initialisation

Minor fixes

…riginal repo

fix: Add xerces-c_3_2.dll to fix .dll no found issue, issue FashionFreedom#1018

CLAassistant · 2024-07-11T11:35:59Z

All committers have signed the CLA.

what-the-diff · 2024-07-11T11:36:17Z

🎉 PR Summary

👍 The hard work and dedication are definitely paying off, folks! 🚀 Here's an easy-to-digest birds-eye view of the progress in this PR:

Updates done in the Continuous Integration Process
We have updated our system's 'knowledge' to a more recent version (6.5.3 as opposed to 6.5.2) to make our testing and building process faster and more secure! Inside baseball: this update was done in the .github/workflows/ci.yml file.🏗️
Refining Our Ignore List
A minor adjustment in our .gitignore file is done to ensure we keep our repository clean and focused, excluding some unnecessary technical files (specifically xerces-c_3_2.dll) from our file tracking system.🗑️
Improving Our Code's Efficiency
We've given some variables (like modeStr in export_layout_dialog.cpp) better default values for better performance and to avoid potential bugs. It's all about the details!🔎
Enhancing Robustness
By adding qobject.h in our ifdef.cpp code file, we've broadened the abilities of our code, making it more versatile and fortified. 💪
Library Addition
We have included a new file (xerces-c_3_2.dll) within src/libs/xerces-c/msvc/lib/ that contributes to the better functioning of our application. Bigger and better, folks!📚

Let's keep this amazing momentum up and continue reaching for the stars! 🌟

csett86

How is the dll built, which version of xerces is used here? Please document that so that we can keep it in sync if an update to xerces is required

csett86 · 2024-07-11T16:26:06Z

src/app/seamly2d/dialogs/export_layout_dialog.cpp

@@ -763,7 +763,7 @@ void ExportLayoutDialog::writeSettings() const
 */
 QString ExportLayoutDialog::modeString() const
 {
-    QString modeStr = QStringLiteral();
+    QString modeStr = QStringLiteral("");


Why this unrelated change here?

I think the compiler was complaining... the current Qt 5 is using QString modeStr = QStringLiteral("");

I must have made the change sometime between the Qt6 branch and now.

I found that the change was commited on the "develop" branch on this commit

I will omit this change from the PR because it only produces a clang warning and doesn't crash the program

csett86 · 2024-07-11T16:26:31Z

src/libs/ifc/ifcdef.cpp

@@ -64,6 +64,7 @@
 #include <QString>

 #include "../vmisc/diagnostic.h"
+#include "qobject.h"


Why this additional include?

Do you mean #include "../vmisc/diagnostic.h"?... which is already included in ifcdef.h

This is another place where the DRS fork and the Seamly repo diverged. This issue was fixed here. I'll change this PR to implement the fix in that PR.

csett86 · 2024-07-11T16:33:12Z

@xypp3 for more details see #1011

csett86

See previous comments and inline

slspencer · 2024-07-11T16:58:53Z

@DSCaskey - Would you be so kind as to enter into these comments how to fix the Linux Fails during builds on the latest GitHub runners? A bulleted list of steps to take would be beneficial.

csett86 · 2024-07-11T20:00:54Z

I can fix the windows mingw build in a separate PR.

The linux builds are fine, no need to do there anything.

And for the unit tests, they are still on the initial to do list since last May (#949), so I would suggest to tackle them also separately.

csett86 · 2024-07-11T20:50:51Z

I have fixed the CI topics in #1146, please review there @slspencer or @DSCaskey

xypp3 · 2024-07-12T11:04:27Z

@csett86

@xypp3 for more details see #1011

This is where we got the .dll from. I will include this detail in the main PR

This reverts commit 78f973b.

xypp3 and others added 8 commits April 18, 2024 10:24

Merge pull request #3 from FashionFreedom/qt6

83c1433

Merge Qt6 branch from main Seamly2D repository

fix: Include qobject.h and Add string literal to fix warnings

d75d936

Revert "fix: Include qobject.h and Add string literal to fix warnings"

215dab8

This reverts commit d75d936.

fix: Include <qobject.h> in ifcdef.cpp && Add string literal in QStri…

2febc55

…ngLiteral object initialisation

Merge pull request #4 from De-Rossi-Consulting/minor-fixes

bbfb72e

Minor fixes

fix: Add xerces-c_3_2.dll to fix .dll no found issue, issue#1018 in o…

29125f8

…riginal repo

Merge pull request #5 from De-Rossi-Consulting/fix-xerces-found

d045623

fix: Add xerces-c_3_2.dll to fix .dll no found issue, issue FashionFreedom#1018

ci: Upgrade Qt version from 6.5.2 to 6.5.3

78f973b

slspencer self-assigned this Jul 11, 2024

slspencer self-requested a review July 11, 2024 16:07

slspencer removed their assignment Jul 11, 2024

slspencer approved these changes Jul 11, 2024

View reviewed changes

csett86 reviewed Jul 11, 2024

View reviewed changes

csett86 requested changes Jul 11, 2024

View reviewed changes

csett86 linked an issue Jul 11, 2024 that may be closed by this pull request

Build: xerces error on Windows/qt6 #1018

Open

xypp3 added 5 commits July 12, 2024 12:06

PR feedback to remove/inline divergences

49ea0f3

Merge branch 'qt6' of github.com:De-Rossi-Consulting/Seamly2D into qt6

e199edc

Revert "ci: Upgrade Qt version from 6.5.2 to 6.5.3"

d643b29

This reverts commit 78f973b.

rm superflous asset files

d4e8004

rm: another batch of extra .val files

f0e6c17

csett86 changed the title ~~fix: Qt6 xerces.dll missing (issue#1018)~~ qt6: fix xerces.dll missing when running from Qt Creator Jul 13, 2024

csett86 changed the title ~~qt6: fix xerces.dll missing when running from Qt Creator~~ qt6(msvc): fix xerces.dll missing when running from Qt Creator Jul 13, 2024

csett86 merged commit e1338cd into FashionFreedom:qt6 Jul 13, 2024
7 of 10 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

qt6(msvc): fix xerces.dll missing when running from Qt Creator #1144

qt6(msvc): fix xerces.dll missing when running from Qt Creator #1144

xypp3 commented Jul 11, 2024 •

edited by csett86

Loading

CLAassistant commented Jul 11, 2024 •

edited

Loading

what-the-diff bot commented Jul 11, 2024

csett86 left a comment

csett86 Jul 11, 2024

DSCaskey Jul 11, 2024

xypp3 Jul 12, 2024

csett86 Jul 11, 2024

DSCaskey Jul 11, 2024

xypp3 Jul 12, 2024

csett86 commented Jul 11, 2024

csett86 left a comment

slspencer commented Jul 11, 2024

csett86 commented Jul 11, 2024

csett86 commented Jul 11, 2024

xypp3 commented Jul 12, 2024 •

edited

Loading

qt6(msvc): fix xerces.dll missing when running from Qt Creator #1144

qt6(msvc): fix xerces.dll missing when running from Qt Creator #1144

Conversation

xypp3 commented Jul 11, 2024 • edited by csett86 Loading

fix: Qt6 xerces.dll missing

TLDR

Description

Problem

Fix

Demo

Build Environment

CLAassistant commented Jul 11, 2024 • edited Loading

what-the-diff bot commented Jul 11, 2024

🎉 PR Summary

csett86 left a comment

Choose a reason for hiding this comment

csett86 Jul 11, 2024

Choose a reason for hiding this comment

DSCaskey Jul 11, 2024

Choose a reason for hiding this comment

xypp3 Jul 12, 2024

Choose a reason for hiding this comment

csett86 Jul 11, 2024

Choose a reason for hiding this comment

DSCaskey Jul 11, 2024

Choose a reason for hiding this comment

xypp3 Jul 12, 2024

Choose a reason for hiding this comment

csett86 commented Jul 11, 2024

csett86 left a comment

Choose a reason for hiding this comment

slspencer commented Jul 11, 2024

csett86 commented Jul 11, 2024

csett86 commented Jul 11, 2024

xypp3 commented Jul 12, 2024 • edited Loading

xypp3 commented Jul 11, 2024 •

edited by csett86

Loading

CLAassistant commented Jul 11, 2024 •

edited

Loading

xypp3 commented Jul 12, 2024 •

edited

Loading