Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build: xerces error on Windows/qt6 #1018

Open
slspencer opened this issue Aug 23, 2023 · 1 comment · Fixed by #1144
Open

Build: xerces error on Windows/qt6 #1018

slspencer opened this issue Aug 23, 2023 · 1 comment · Fixed by #1144
Labels
build

Comments

@slspencer
Copy link
Collaborator

Describe the problem or new action
Build with QtCreator on Windows with qt6.5.2, then run in Debug mode. Generates error message that the xerces-c_3_2.dll file can't be found.

The src/libs/xerces-x/msvc files were originally
xerces-c_3.lib
After compiling Seamly2D with QtCreator on Windows, two additional files appeared:

Is this for a particular OS?
Windows

Can this be handled in Github Actions (https://github.com/marketplace?type=actions)
No.

Screenshot
xerces-windows-error
@csett86
Copy link
Member

csett86 commented Aug 23, 2023

Was this with msvc or mingw on windows?

@xypp3 xypp3 mentioned this issue Apr 18, 2024
Merged
Martin-Nyaga added a commit to De-Rossi-Consulting/Seamly2D that referenced this issue May 10, 2024
@Martin-Nyaga
Merge pull request #5 from De-Rossi-Consulting/fix-xerces-found
d045623 
fix: Add xerces-c_3_2.dll to fix .dll no found issue, issue FashionFreedom#1018
@xypp3 xypp3 mentioned this issue Jul 11, 2024
Merged
@csett86 csett86 linked a pull request Jul 11, 2024 that will close this issue
qt6(msvc): fix xerces.dll missing when running from Qt Creator #1144
Merged
csett86 pushed a commit that referenced this issue Jul 13, 2024
@xypp3 @Martin-Nyaga
qt6(msvc): fix xerces.dll missing when running a build from Qt Creator (
e1338cd 
#1144)

# fix: Qt6 xerces.dll missing
## TLDR
Fix issue that caused Qt6 Seamly2D `xerces-c_3_2.dll` not be be compiled by including it directly in the library folder.

## Description
For the last couple of weeks we have been working on understanding the issues that stood in the way of Qt6. We've been in commuincation with Sue (Github username: @slspencer). This PR originates from the "qt6" branch and is intend to be merged back into it.

### Problem
This PR fixes issue presented in [issue#1018](#1018). The issue states that when trying to compile Seamly2D on Windows 10 with MSVC19, the build failed. Screenshot below is taken from issue page:

![screeshot showing xerces.dll not found](https://github.com/FashionFreedom/Seamly2D/assets/32486789/d4bc96e1-4995-42cf-ada2-f9f5c3b50c53)


### Fix
The compiled xerces-c_3_2.dll is placed inside the `src/libs/xerces/msvc` folder. The .dll was taken from the [Seamly xerces hosted assets](https://github.com/FashionFreedom/xerces-c/releases/tag/v3.2.4)

### Demo
Video below shows both Qt6 version of Seamly2D compiling and being able to open files without freezing/crashing:
[video demo of fixed Qt6 Seamly2D](https://youtu.be/zEaoEWSGHpQ?feature=shared)

## Build Environment
**TLDR:** This was tested on a VM running Windows 10.

For more details on the build environment read the [gist linked here](https://gist.github.com/xypp3/8a7b77b30fb1cfdec6378a5fdee1bf9a)

---------

Co-authored-by: Martin Nyaga <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
build
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

qt6(msvc): fix xerces.dll missing when running from Qt Creator De-Rossi-Consulting/Seamly2D
2 participants
@slspencer @csett86