Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Produce memory leak (issue #602) #605

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 23 additions & 12 deletions src/KafkaFlow/Producers/MessageProducer.cs
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
using System;
using System.Text;
using System.Threading.Tasks;
using Confluent.Kafka;
using KafkaFlow.Authentication;
using KafkaFlow.Configuration;
using System;
using System.Text;
using System.Threading.Tasks;

namespace KafkaFlow.Producers;

Expand Down Expand Up @@ -334,20 +334,31 @@ private void InternalProduce(
var localProducer = this.EnsureProducer();
var message = CreateMessage(context);

if (partition.HasValue)
try
{
if (partition.HasValue)
{
localProducer.Produce(
new TopicPartition(context.ProducerContext.Topic, partition.Value),
message,
Handler);

return;
}

localProducer.Produce(
new TopicPartition(context.ProducerContext.Topic, partition.Value),
context.ProducerContext.Topic,
message,
Handler);

return;
}

localProducer.Produce(
context.ProducerContext.Topic,
message,
Handler);
catch (Exception ex)
{
DeliveryReport<byte[], byte[]> report = new()
{
Error = new Error(ErrorCode.Local_Fatal, ex.Message, isFatal: true),
};
Handler(report);
}

void Handler(DeliveryReport<byte[], byte[]> report)
{
Expand Down