feat: Create topic with additional configuration if present #601
+19
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertcoltheart
changed the title
robertcoltheart
force-pushed
the
feature/topic-creation-configs
branch
from
8832d81 to
fb3b005
Compare
robertcoltheart
force-pushed
the
feature/topic-creation-configs
branch
from
fb3b005 to
f34011b
Compare
robertcoltheart
commented
Nov 6, 2024
| @@ -3,12 +3,12 @@ | |||
| init_broker: | |||
| @echo command | date | |||
| @echo Initializing Kafka broker | |||
| docker-compose -f docker-compose.yml up -d | |||
| docker compose -f docker-compose.yml up -d | |||
There was a problem hiding this comment.
Fixed the makefile, since it was failing to build due to using the wrong command under latest Ubuntu
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Passes additional configuration options, if present, to the topic creation method.
Fixes #600
How Has This Been Tested?
Please describe the tests that you ran to verify your changes.
Checklist
Disclaimer
By sending us your contributions, you are agreeing that your contribution is made subject to the terms of our Contributor Ownership Statement