feat: Allow consumers to start from a specified offset #585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nualAssignPartitionsOffset
tests/KafkaFlow.IntegrationTests/Core/Handlers/MessageStorage.cs
Outdated
Show resolved
Hide resolved
brmagadutra
approved these changes
Aug 29, 2024
kikofps
approved these changes
Aug 29, 2024
Waddas
force-pushed
the
feature/Consumer-ManualAssignPartitionsOffset
branch
from
5b91da5 to
130775a
Compare
RXFB
approved these changes
Aug 29, 2024
JoaoRodriguesGithub
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implemented
ManualAssignPartitionOffsetsto allow consumers to start consuming from a specified offset.Fixes #584
How Has This Been Tested?
I've added
ManualAssignPartitionOffsetsTestinto the integration test suite. This uses the bootstrapped service provider to place 10 messages into a topic initially. It then creates a new service provider with a consumer to start at offset 5. The test verifies that the consumer only consumes messages at offsets 5 - 9.I've added a ServiceProviderHelper to aid in the creation of the provider and refactored the GlobalEventTests to reduce code duplication.
Manual tests to verify consumers are starting from the specified offsets.
Checklist
Notes
I had to convert SaslOauthbearerMethod.cs to a file-scoped namespace or the solution would not build. Happy to revert this if needed.
Disclaimer
By sending us your contributions, you are agreeing that your contribution is made subject to the terms of our Contributor Ownership Statement