Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: out of order production issue #567

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
+176 −166
Draft

fix: out of order production issue #567

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 8 additions & 9 deletions src/KafkaFlow.Abstractions/Configuration/SaslOauthbearerMethod.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,11 @@
namespace KafkaFlow.Configuration
namespace KafkaFlow.Configuration;

/// <summary>SaslOauthbearerMethod enum values</summary>
public enum SaslOauthbearerMethod
{
/// <summary>SaslOauthbearerMethod enum values</summary>
public enum SaslOauthbearerMethod
{
/// <summary>Default</summary>
Default,
/// <summary>Default</summary>
Default,

/// <summary>Oidc</summary>
Oidc,
}
/// <summary>Oidc</summary>
Oidc,
}
2 changes: 2 additions & 0 deletions src/KafkaFlow/Producers/IMessageProducer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,7 @@ Task<DeliveryResult<byte[], byte[]>> ProduceAsync(
/// <param name="headers">The message headers</param>
/// <param name="deliveryHandler">A handler with the operation result</param>
/// <param name="partition">The partition where the message will be produced, if no partition is provided it will be calculated using the message key</param>
[Obsolete("This method will be remove in the next major release, please use ProduceAsync() instead")]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we marking the Produce methods as obsolete? In scenarios where the message throughput is high, the non async producer can produce at a significant higher rate since it doesn't need to wait for the report.

Why can't the framework support this?

void Produce(
string topic,
object messageKey,
Expand All @@ -79,6 +80,7 @@ void Produce(
/// <param name="headers">The message headers</param>
/// <param name="deliveryHandler">A handler with the operation result</param>
/// <param name="partition">The partition where the message will be produced, if no partition is provided it will be calculated using the message key</param>
[Obsolete("This method will be remove in the next major release, please use ProduceAsync() instead")]
void Produce(
object messageKey,
object messageValue,
Expand Down
Loading
Loading