Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement registration form #80

Merged
merged 4 commits into from
Aug 13, 2024
Merged

Implement registration form #80

merged 4 commits into from
Aug 13, 2024

Conversation

dheidemann
Copy link
Member

@dheidemann dheidemann commented Aug 11, 2024

google forms api sucks, implemented registration form functionality myself now.

Each umbrella event can have a registration form now.
I seed a default form for a umbrella event with id 1.
Therefore the registration form can be found at http://localhost:8080/registration?e=1

For the reviewer: you dont need to check the backend stuff, just fronted please. Basically the only relevant file is frontend/app/registration/page.tsx

@dheidemann dheidemann added the enhancement New feature or request label Aug 11, 2024
@dheidemann dheidemann self-assigned this Aug 11, 2024
@dheidemann dheidemann linked an issue Aug 11, 2024 that may be closed by this pull request
Copy link
Contributor

@Plebysnacc Plebysnacc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Validation Check is not always needed, makes the form invalid although valid answers may have been given

image

@dheidemann
Copy link
Member Author

This is something i cannot represent in the datastructure. You would have to add another answer with 'Kenne ich alles' for example

@dheidemann
Copy link
Member Author

Well you could add this 0 point answer and if it exists i skip the form validation and dont show the answer. A bit sketchy tho

@dheidemann
Copy link
Member Author

Nevermind, i have a better idea, gimme 5 min

@Plebysnacc
Copy link
Contributor

Is not having a notification for completed submission intended?

@dheidemann
Copy link
Member Author

the submission flow is not part of this pr. This needs another table in the database and is going to be implemented afterwards

Copy link
Contributor

@Plebysnacc Plebysnacc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dheidemann dheidemann merged commit 0ab58df into main Aug 13, 2024
2 checks passed
@dheidemann dheidemann deleted the quiz branch August 13, 2024 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

discussion: best way to implement registration form for students
2 participants